CASSANALYTICS-146: Remove shutdownhooks in testing to prevent race on…#192
Open
jmckenzie-dev wants to merge 1 commit intoapache:trunkfrom
Open
CASSANALYTICS-146: Remove shutdownhooks in testing to prevent race on…#192jmckenzie-dev wants to merge 1 commit intoapache:trunkfrom
jmckenzie-dev wants to merge 1 commit intoapache:trunkfrom
Conversation
… transaction log deletion Patch by Josh McKenzie; reviewed by TBD for CASSANALYTICS-146
Contributor
jyothsnakonisa
left a comment
jyothsnakonisa
left a comment
There was a problem hiding this comment.
Looks good just few minor comments. Not sure if you need to add this to changes.txt
| // and transaction log I/O races w/shutdowns from our tests here. Rather than get extra insult to injury if a | ||
| // test times out, we instead unregister the StorageService shutdown hooks; we don't much care about memtable | ||
| // content from a node getting flushed with unit tests that run ephemerally. | ||
| // If in the future we start to rely on stopping and starting C* nodes and the StorageService shutdown hooks |
Contributor
There was a problem hiding this comment.
Did you miss completing the comment?
| } | ||
| catch (Throwable t) | ||
| { | ||
| logger.debug("Failed to remove shutdown hook for instance {}", i, t); |
Contributor
There was a problem hiding this comment.
Should we make the log info level to view the log in the CI output when something goes wrong?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… transaction log deletion
Patch by Josh McKenzie; reviewed by TBD for CASSANALYTICS-146